cvs commit: src/usr.bin/make job.c
Hartmut Brandt
harti at FreeBSD.org
Thu Nov 25 02:01:26 PST 2004
harti 2004-11-25 10:01:26 UTC
FreeBSD src repository
Modified files:
usr.bin/make job.c
Log:
Fix a very long-standing error in handling .SHELL targets: this target
uses the brk_string function to parse the line. That function uses static
storage for both the expanded string and the returned argv[] vector.
The JobParseShell function simply stored away pointers into this static
storage. On the next use of something like ${FOO:O} this storage would
get overwritten with fatal results.
This also allows us to make the shells[] array const bringing us one step
further in making make WARNS=4 ready.
Revision Changes Path
1.60 +125 -46 src/usr.bin/make/job.c
More information about the cvs-src
mailing list