cvs commit: src/sys/pci if_sk.c

[John-Mark Gurney]

Ruslan Ermilov wrote this message on Thu, Nov 18, 2004 at 00:43 +0200:
> My old patch (that I didn't commit due to the lack of h/w),
> resets IFF_OACTIVE inside the while() loop, like this:
> 
>                 sc_if->sk_cdata.sk_tx_cnt--;
> +               ifp->if_flags &= ~IFF_OACTIVE;
>                 SK_INC(idx, SK_TX_RING_CNT);
> 
> I believe this is more correct than what got committed,
> but I cannot prove it.  ;)

considering that we hold the lock over the while loop, and then call
sk_start before the lock gets unlocked... :)

I have a similar patch for if_re that I need to try out...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."