cvs commit: src/sys/dev/uart uart_subr.c

[Poul-Henning Kamp]

In message <200411142138.iAELcM5h018562 at repoman.freebsd.org>, Marcel Moolenaar 
writes:
>marcel      2004-11-14 21:38:22 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/dev/uart         uart_subr.c 
>  Log:
>  Make sure the baudrate specified with the BR tag is somewhat sane.
>  A baudrate we consider insane is silently replaced with 0. When the
>  baudrate is 0, we will not try to program the hardware. Instead we
>  leave the communication speed unaltered, maximizing the chance to
>  have a working console. Obviously this means we allow specifying a
>  0 baudrate for exactly that purpose.

Setting a zero speed used to have magic meaning, sometimes sending
a break, on other systems it would hang up the line.  Overloading
with yet a meaning may not be a good idea.  (I'm not sure what
the standards demand btw).

How about using -1 instead ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.