cvs commit: src/sys/dev/em if_em.c

[John Baldwin]

On Wednesday 03 November 2004 11:37 am, Scott Long wrote:
> Luigi Rizzo wrote:
> > On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote:
> > ...
> >
> >>I think that in general we can start eyeing a lot of similar verbosity
> >>in all of our drivers, both at boot and at runtime.  For example most
> >>nic drivers print out their MAC and all of their possible negotiation
> >>rates on attach.  This same info can be obtained from ifconfig.  Why
> >>clutter the boot with it?
> >
> > because sometimes you might need to enable some MAC-based filter
> > before you have a chance to access the box. e.g. to set dhcp/bootp
> > anbd the like.
> >
> > A bit of verbosity is useful, you can always switch to splash screens
> > if you don't like them.
> >
> > I think the link-up/link-down thing is different because it
> > happens not just at boot but also whenever the link status
> > changes (e.g. when a spanning tree on a switch detects a
> > reconfiguration), and this is annoying on the console.
> >
> > cheers
> > luigi
>
> I'm not saying that these things should be removed, just places under
> bootverbose.  Situations like what you are saying are rare and/or
> one-time occurances.  And if you look at drivers like if_ath(no offense
> meant towards Sam):

I think bootverbose needs to be split up some.  Imagine having a 
'verbose.ether' tunable that would turn on dumping all the MAC addresses for 
NICs but would be off by default.  Many of the interrupt messages on x86 need 
to move from bootverbose to some kind of apic_verbose.  Might even be nice to 
have some kind of acpi-like verbose variable that could be set as:

set verbose="boot,apic,ether"

or some such.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org