cvs commit: src/sys/dev/em if_em.c

Scott Long scottl at freebsd.org
Wed Nov 3 08:52:53 PST 2004


M. Warner Losh wrote:
> In message: <418905E5.1050605 at freebsd.org>
>             Scott Long <scottl at FreeBSD.org> writes:
> : Poul-Henning Kamp wrote:
> : > phk         2004-11-03 14:11:18 UTC
> : > 
> : >   FreeBSD src repository
> : > 
> : >   Modified files:
> : >     sys/dev/em           if_em.c 
> : >   Log:
> : >   Put the "Link is up/down" printfs behind bootverbose.  gigE is not so uncommon
> : >   that we need to tell people about every cable in the network anymore.  It can
> : >   be enabled for debugging purposes with "boot -v".
> : >   
> : >   Revision  Changes    Path
> : >   1.51      +8 -6      src/sys/dev/em/if_em.c
> : 
> : I think that in general we can start eyeing a lot of similar verbosity
> : in all of our drivers, both at boot and at runtime.  For example most
> : nic drivers print out their MAC and all of their possible negotiation
> : rates on attach.  This same info can be obtained from ifconfig.  Why
> : clutter the boot with it?
> 
> Well, you can't get all the info you need from ifconfig.  If you want
> to know WHICH nic is in WHAT slot, it is a lot easier to get that from
> the one liner printed on boot (especially when trying to troubleshoot
> things) than to get it from ifconfig + dmesg.  I think that's useful
> to continue to have there.
> 
> I do agree that the rate thing of the wireless drivers is excessive,
> as is many of the rate things.
> 
> fwohci likely can use some trimming as well, even in the non-verbose
> mode.
> 
> The CAM messages are the only messages in FreeBSD more verbose than
> VMS :-)
> 
> Warner

I've looked at the CAM messages, yes.  I'm not calling for immediate
action, just saying that it's something to keep an eye on and think
about.

Scott


More information about the cvs-src mailing list