cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h

[Ruslan Ermilov]

On Tue, May 25, 2004 at 09:34:59PM +0400, Yar Tikhiy wrote:
> On Tue, May 25, 2004 at 07:42:51PM +0300, Ruslan Ermilov wrote:
> > On Tue, May 25, 2004 at 07:49:46AM -0700, Yar Tikhiy wrote:
> > > yar         2004/05/25 07:49:46 PDT
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/dev/fxp          if_fxp.c if_fxpvar.h 
> > >   Log:
> > >   Teach fxp(4) to control VLAN_MTU in the hardware.
> > >   Now reception of extended frames can be toggled
> > >   through ioctl(SIOCSIFCAP).
> > >   
> > >   The card will also receive extended frames when
> > >   in promiscuous mode.
> > >   
> > >   Revision  Changes    Path
> > >   1.209     +16 -8     src/sys/dev/fxp/if_fxp.c
> > >   1.30      +1 -0      src/sys/dev/fxp/if_fxpvar.h
> > > 
> > This change also made VLAN_MTU disabled by default, what was
> > the reason to do it?
> 
> I disabled it so that the interface won't violate without need
> the Ethernet standard WRT the upper limit on frame size.
> 
What clause and in which of many 802 standards do you refer to?

> vlan(4) will enable VLAN_MTU on an fxp interace as soon as a vlan
> interface is attached to it.
> 
vlan(4) may not be the only consumer of VLAN capable frames.
For example, I have ng_vlan(4) connected to ng_ether(4) node,
and doing VLAN processing here, and this change will break
the existing and working config.  I can survive, but it sounds
against POLA to me.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040525/1fc5e183/attachment.bin