cvs commit: src/sys/dev/led led.h

[John Baldwin]

On Tuesday 11 May 2004 03:23 pm, Nate Lawson wrote:
> On Tue, 11 May 2004, Colin Percival wrote:
> > At 19:15 11/05/2004, David O'Brien wrote:
> > >On Tue, May 11, 2004 at 10:02:59AM -0700, Nate Lawson wrote:
> > >> Do we even want __FBSDID in .h files?  It doesn't seem to make sense
> > >> since it's not a compilation unit (i.e. no linkage).
> > >
> > >It actually does make sense, as a header's contents does wind up in a .o
> > >eventually :-)  And header contents can be the cause of problems as much
> > >as a .c file.  There is no problem having multiple __FBSDID in either
> > >a.out or ELF objects.
> >
> > However, there are problems with having a header file's __FBSDID tags end
> > up in a several binaries.  Quite apart from the resulting bloat, most
> > changes to header files don't actually result in many binaries being
> > modified; including compilable $Id$ tags in the headers would result in
> > lots of spurious binary changes.  This would make me (and anyone who uses
> > FreeBSD Update) very unhappy.
>
> I agree.  This creates the same problems as panic() now changing object
> files every time a comment is moved or other non-functional change.

Seconded on both counts.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org