cvs commit: src/sys/amd64/isa atpic.c src/sys/contrib/dev/oltr if_oltr.c src/sys/dev/aac aac_pci.c src/sys/dev/acpic

[M. Warner Losh]

In message: <20040322191542.CD8DE16A4CF at hub.freebsd.org>
            wpaul at FreeBSD.org (Bill Paul) writes:
: static __inline struct resource *
: bus_alloc_resource_any(device_t dev, int type, int *rid, u_int flags)
: {
:         return (bus_alloc_resource(dev, type, rid, 0ul, ~0ul, 1, flags));
: }
: 
: Please to be explaining why this isn't a macro:
: 
: #define bus_alloc_resource_any(dev, type, rid, flags)	\
: 	bus_alloc_resource(dev, type, rid, 0ul, ~0ul, 1, flags)

Because they are the same thing, and the inline is easier to deal with
and have fewer side effects.  If you are going give Nate a hassle
about it, don't.  I told him to do it that way.  Also, your macro is
wrong in that it doesn't have enough ().

Warner