cvs commit: src/sys/amd64/isa atpic.c src/sys/contrib/dev/oltr if_oltr.c src/sys/dev/aac aac_pci.c src/sys/dev/acpica/Os

[Nate Lawson]

On Sun, 21 Mar 2004, Bill Paul wrote:
> > njl         2004/03/17 09:50:55 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> [...]
> >     sys/dev/if_ndis      if_ndis_pccard.c if_ndis_pci.c
> [...]
> >   Log:
> >   Convert callers to the new bus_alloc_resource_any(9) API.
> >
> >   Submitted by:   Mark Santcroos <marks at ripe.net>
> >   Reviewed by:    imp, dfr, bde
>
> :(
>
> By doing this, you have fixed it to people can't use the NDISulator
> code on 5.2-RELEASE or 5.2.1-RELEASE. I think it is hardly worth it
> to break source code compatibility in this case just to avoid having
> to type a few extra arguments. At the very least, bus_alloc_resource_any()
> could have been implemented as a macro: then I could just test for its
> existence and #define it myself so the code would run on older systems.
> I'm very susprised that bde never raised this point.

Bill, I can understand that you're upset.  The reason why we made this
change now is that API compatibility needs to be fixed before 5.3R.  I
MFCd the function itself to 4-STABLE, but it won't go into 5.2 or 5.2.1
due to the fact that only security changes are allowed there.

Perhaps I should do a version bump?  Then you can add have source
compatibility with 5.2*.  In any case, I would appreciate it if you'd go
back to the convenience function before 5.3R branches so that 5.3R and
5-stable will have the new api.

The reason for this change, BTW, is to unify a function for people who
just want whatever resource is at a given RID.  Some drivers were
specifying different values even though they wanted the default.

Thanks,
-Nate