cvs commit: src/share/mk bsd.cpu.mk bsd.dep.mk bsd.lib.mk bsd.sys.mk src/sys/conf files kern.mk kern.pre.mk kmod.mk src/sys/dev/aic7xxx/aicasm Makefile

[Ruslan Ermilov]

On Sat, Mar 13, 2004 at 10:57:19AM +0100, Alexander Leidinger wrote:
> On Fri, 12 Mar 2004 23:56:49 +0200
> Ruslan Ermilov <ru at freebsd.org> wrote:
> 
> > > Index: src/share/mk/bsd.lib.mk
> > > diff -u src/share/mk/bsd.lib.mk:1.156 src/share/mk/bsd.lib.mk:1.157
> > > --- src/share/mk/bsd.lib.mk:1.156	Tue Jan 27 15:22:15 2004
> > > +++ src/share/mk/bsd.lib.mk	Fri Mar 12 13:36:12 2004
> > [...]
> > > +.c.o:
> > > +	${CC} ${CFLAGS} -c ${.IMPSRC} -o ${.TARGET}
> > > +
> > > 
> > Please revert the addition of this, it's bogus and duplicated
> > what's already in sys.mk.
> 
> Ooops... sorry. I think this bogus change crept in at the time you moved
> this part to sys.mk (at least I think you did something like this, and I
> forgot to review your change entirely).
> 
OK.  Tom will take care of this.

> > > -.endif !defined(INTERNALLIB)
> > > +.endif #!defined(INTERNALLIB)
> > >  
> > Please revert this.
> 
> Why? .endif doesn't take an argument and it serves as a comment. So why
> not make it explicit? I would agree with adding a space after the
> comment sign, but I don't understand why it should be reverted.
> 
Because it has nothing to do with ICC support.  Because other places
in share/mk spell it like this.  Because I prefer it this way.  ;)


Cheers,
-- 
Ruslan Ermilov
FreeBSD committer
ru at FreeBSD.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040313/78224981/attachment.bin