cvs commit: src/sys/vm vm_map.c

Andrew Gallatin gallatin at cs.duke.edu
Tue Jun 29 05:13:19 PDT 2004


Bruce Evans writes:
 > On Mon, 28 Jun 2004, Andrew Gallatin wrote:
 > 
 > > Brian Fundakowski Feldman writes:
 > >  > On Mon, Jun 28, 2004 at 03:22:33PM -0400, Andrew Gallatin wrote:
 > >  > > Andrew Gallatin [gallatin at FreeBSD.org] wrote:
 > >  > > > gallatin    2004-06-28 19:15:40 UTC
 > >  > > >
 > >  > > >   FreeBSD src repository
 > >  > > >
 > >  > > >   Modified files:
 > >  > > >     sys/vm               vm_map.c
 > >  > > >   Log:
 > >  > > >   Fix alpha - the use of min() on longs was loosing the high bits and
 > >  > > >   returning wrong answers, leading to strange values vm2->vm_{s,t,d}size.
 > 
 > MIN() and MAX() should not be used in the kernel.  4.4BSD removed them in
 > the kernel, but FreeBSD broke this in rev.1.141 of sys/param.h.  They
 > remain removed in RELENG_4.
 > 

OK.  Then what's the correct fix? ulmin()?

Thanks,

Drew


More information about the cvs-src mailing list