cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c

David O'Brien obrien at FreeBSD.org
Sat Jun 26 20:36:30 PDT 2004


On Fri, Jun 25, 2004 at 12:38:27PM +0000, Alexander Kabaev wrote:
> On Fri, Jun 25, 2004 at 02:16:27PM +0200, Dag-Erling Sm?rgrav wrote:
> > Ruslan Ermilov <ru at FreeBSD.org> writes:
> > > On Fri, Jun 25, 2004 at 11:28:50AM +0200, Dag-Erling Sm?rgrav wrote:
> > > > Alexander Kabaev <kan at FreeBSD.org> writes:
> > > > >   Log:
> > > > >   Remove the use of cast as lvalue.
> > > > This trades one style bug for another (missing space before *), breaks
> > > > the build on 64-bit platforms, and violates maintainership.
> > > Ah, so this commit is responsible for a cross-build breakage...
> > 
> > No, this one currently only breaks Alpha because we apparently don't
> > enforce alignment requirements on other platforms.
> > 
> It definitely worked for amd64 world, which I guess does not have such
> strict alignment requirements.

Not at all -- AMD64 is an x86 platform first and fore most.  That means
no traps or exceptions on misalignments like for Alpha and other RISC
platforms.  There is of course a performance degradation on AMD64, but
its the same as misalignments for x86 32-bit.

-- 
-- David  (obrien at FreeBSD.org)


More information about the cvs-src mailing list