cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf.c uipc_syscalls.c src/usr.bin/netstat mbuf.c src/lib/libc/sys sendfile.2

[Mike Silbersack]

> On Fri, Jun 18, 2004 at 03:48:13AM +0700, Max Khon wrote:
>
> This particular change is a case of nit-picking.  It's small, hard to
> imagine how it could effect someone, etc.  But even Bosko said more
> caution 'next time' would be good, I'm just emphasizing why.  To some
> extent the output of programs has been an API ever since pipes were
> invented.  And unless I'm severely mistaken one of the things we have
> tried to avoid is changing API's once a branch goes -STABLE.
>
> --
> 						Ken Smith

Yes, you hit it right on the head, this IS a case of nitpicking.

sfbufs are used almost exclusively in conjunction with mbufs, and users
who are interested in mbuf usage will certainly be interested in sfbuf
usage.  This is why I displayed the information along with mbuf
statistics, and why I see no reason to add yet another switch to netstat
(or would it be sfstat?)

I understand the script breakage argument, but I don't think it's
particularly potent.  Imagine this:  We have ls, but it doesn't list file
sizes, and there was no previous tool to list file sizes.  Someone comes
along and adds file size display to ls.  However, due to objections about
scripts breaking, this is backed up, and a seperate option , "ls -f" is
added, which lists file sizes.  This is the situation we're in here -
there was NO previous way to see sfbuf statistics; we're adding new _and_
relevant data to "netstat -m".

The implementation is an entirely different story, and I'm not disputing
that it could be done better.

Mike "Silby" Silbersack