cvs commit: src/sys/dev/sound/pci emu10k1.c

David O'Brien obrien at freebsd.org
Tue Jun 15 23:11:13 GMT 2004


On Tue, Jun 15, 2004 at 03:18:34PM -0600, Scott Long wrote:
> It's fine to put an unknown ID into a driver to do local testing and 
> discovery.  It's less acceptable to commit that change to FreeBSD CVS
> without knowing what it does and what impact it has.  Anyways, this
> has been kicked around enough and I believe that David already said
> that he will back out the change.

I didn't say I plan to back it out -- I said if pushed to I would.
Meaning I wont fight much for it.  I still think there is definate worth
in having the probe message identify the Dell part (so we can find
testers).  There is no bug report against the driver in 5-CURRENT (which
I updated post 5.2.1).

This is has gotten into bikeshead teritory, especially since I'm the
closest thing we've had to a emu10k1 maintainer in 2-3 years.

As other have said: A sound driver probing, attaching, and failing to
work is orders of magnitude less an issue than for some other classes of
drivers.

-- 
-- David  (obrien at FreeBSD.org)


More information about the cvs-src mailing list