cvs commit: src/usr.sbin/ntp config.h src/usr.sbin/ntp/ntpdc Makefile src/usr.sbin/ntp/ntpq Makefile

[Giorgos Keramidas]

On 2004-07-22 21:58, Tim Robbins <tjr at freebsd.org> wrote:
>On Thu, Jul 22, 2004 at 01:59:15PM +0300, Giorgos Keramidas wrote:
>>On 2004-07-22 08:14, Ollivier Robert <roberto at freebsd.org> wrote:
>>>
>>> Allow ntpd to be compiled w/o readline when NO_GNU is defined.  Part
>>> of a larger patchset to get a GNU-free world.
>>>
>>> Patch rewritten to cope with the 4.2.0 changes.
>>
>> Just a thought, without having looked at the source of ntp stuff.
>>
>> Would it be extremely difficult or cause conflict/merge problems if we
>> replaced readline with libedit in the NO_GNU case?
>
> NetBSD not-so-recently added GNU readline emulation to their libedit.
> Last time I looked, they'd made a mess of the code with #ifdefs, but it'd
> still be possible to bring across the useful bits.

Err, no that would be ugly.  I don't like excessive use of #ifdefs but
that's probably a different topic.

I was thinking of something more like: use this getline() function,
which will magically work through readline() or el_get() depending on
which file was added to SRCS at compile-time (depending on WITH_READLINE
or not).

> FWIW, I really don't see the point of partial support for building
> GNU-free systems. It sounds like something that should be kept as
> a local diff.

Hmmm, yes well...  I'll see if I can do something not too ugly but still
useful as a proof-of-concept diff when the commits to the ntp utils are
all done.