cvs commit: src/sys/compat/linux linux_socket.c

Sam Leffler sam at errno.com
Sun Jul 18 09:49:46 PDT 2004


On Sunday 18 July 2004 02:26 am, David Malone wrote:
> dwmalone    2004-07-18 09:26:34 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/compat/linux     linux_socket.c
>   Log:
>   I missed two pieces of the commit to this file. Robert has already
>   added one, this adds the other.

Not to pick on this commit, but recently there have been several commits where 
the log msg addressed _why_ the commit was done but never described _what_ 
was changed.  This is not helpful; someone coming along later with only CVS 
for reference must do a diff to even guess what the change does. Good commit 
msgs give a reader an understanding of the reason and content of a change.  

The above commit msg is more appropriate as followup mail to the actual commit 
(so it's not even included in CVS).

	Sam


More information about the cvs-src mailing list