cvs commit: src/sbin/mount mount.c

[Ruslan Ermilov]

On Thu, Jan 29, 2004 at 03:26:59PM +0100, Guido van Rooij wrote:
> On Thu, Jan 29, 2004 at 02:09:55PM +0000, Ceri Davies wrote:
> > On Thu, Jan 29, 2004 at 03:07:40PM +0100, Dag-Erling Sm?rgrav wrote:
> > > Ruslan Ermilov <ru at FreeBSD.org> writes:
> > > > Did you mean -u here, because -a is not listed as allowed
> > > > in combination with the -o option?
> > > 
> > > no, his patch makes
> > > 
> > > # mount -u -o fstab -a -t ufs
> > > 
> > > work as expected (i.e. restore the fstab flags on all ufs filesystems)
> > > 
> > > previously,
> > > 
> > > # mount -u -o fstab /specific/mount/point
> > > 
> > > would work, but the -a version wouldn't.
> > 
> > The manpage and usage bits should be updated to reflect this.  I'm not
> > sure, but I think that's what Ruslan was getting at.
> > 
> 
> I don't get it..it is not specifically mentioned as forbidden. So
> it should work. 
> What Ruslan meant (at least that is how I see it) is that
> -o fstab is only mentioned in combination with -u. That is correct.
> It still works with -a (without the -u), but specifying it is pointless
> as its net effect is nill. So I would not update the manual page.
> 
usage: mount [-dfpruvw] [-o options] [-t ufs | external_type] special node
       mount [-adfpruvw] [ -F fstab] [-t ufs | external_type]
       mount [-dfpruvw] special | node

Can you see the -a option on the first line with -o?  I can't.
The fix is to add -a as allowed option to the first line of
program's usage() and manpage's SYNOPSIS.


Cheers,
-- 
Ruslan Ermilov
FreeBSD committer
ru at FreeBSD.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040129/95ec1d30/attachment-0001.bin