cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h

[John Baldwin]

On Tuesday 20 January 2004 03:39 pm, Poul-Henning Kamp wrote:
> In message <200401201445.24897.jhb at FreeBSD.org>, John Baldwin writes:
> >On Tuesday 20 January 2004 01:23 pm, Poul-Henning Kamp wrote:
> >> In message <200401201234.45472.jhb at FreeBSD.org>, John Baldwin writes:
> >> >On Monday 19 January 2004 04:27 pm, Poul-Henning Kamp wrote:
> >> >>   Log:
> >> >>   Add linenumber and source filename to panic(9) output.
>
> This thread already represents a prime example of the worst of the
> FreeBSD projects social dimension:  The Gratuituos Bike Shed.

You can't pull out that card everytime someone disagrees with you.

> The email generated by this bike-shed however, has already occupied
> more disk-space on my computers than the kernel change ever will,
> and chances are that we have not even seen the tip of that iceberg.

The e-mail in my core@ inbox from you alone more than dwarfs every other 
bikeshed thread known to man, so a pissing contest over mail archive sizes is 
less than useful I think.

> May I kindly remind you all that even if one person doesn't find
> that it adds anything to his already trained skills as a debugger,
> it does make life easier for other less gifted people in our project,
> or God forbid: actual users who may try to report a problem.

By adding even more clutter to a panic message (esp. the fatal page faults 
that happen more often than any other panic) you make it even harder for any 
debugger to glean out the useful information from all of the rest.

> And no, this does not solve the mid-east crisis, but it is still
> an improvement, even for me:  If I save 1 minute because I do not
> have to hunt for the panic in the first place, then that is one
> minute more I can spend on the code.

It is not an improvement in all cases and most of the people in this thread 
have opposed this.  The only response you got on the mailing list to your 
post was a "please do not commit" from Bruce and you went ahead and committed 
anyway.  Do all of our opinions just not count when the Almighty Poul-Henning 
has a patch he wants to commit?

> So if this makes your eyes water, I suggest you comment it out in
> your local source tree and pop in on the next meeting in your
> local user-group for some much needed perspective.

I have been very busy helping people with bug reports including closing PR's 
etc.  I'm not hiding in my white tower cursing users as you seem to imply, so 
you can lay off that lame argument.  In my real world experience, the panic 
message is enough to find where the problem is.  Several of them already 
include far more relevant file and line numbers anyways.  Sometimes a patch 
that looks good to you doesn't look good to everyone else.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org