cvs commit: src/sys/dev/sound/pci neomagic-coeff.h src/sys/dev/sound/pcm dsp.c mixer.c sound.c sound.h vchan.c

[Don Lewis]

On 17 Jan, Poul-Henning Kamp wrote:
> In message <200401171115.i0HBFC7E048300 at gw.catspoiler.org>, Don Lewis writes:
> 
>>>   Log:
>>>   As previously announced:  discontinue use of makedev() call in soundcode.
>>>   
>>
>>Sigh ... I predict hours of entertainment merging this with my pcm/*
>>buffer overflow and locking cleanup patch.
> 
> First of all, I doubt there is much cross-section there, second, this
> patch has been posted twice and I do not recall any email from you
> on that subject.

I haven't looked at your changes, so it is possible that our patches
avoided each other, though I do remember seeing makedev() near some of
the places that I touched.  My patch file has grown to about 1000 lines
and has been posted to current@ a number of times in the last week or
so.

I only landed in the sound code in the last few weeks and only because
that's where I tracked a heap-eating buffer overflow.  I didn't even
have working sound hardware until a day or so ago, so tracking sound
issues has not been a priority for me.

Your changes sound like they are the way forward, so I don't have a
problem with them being committed.  It's just that the timing is
unfortunate that we have both been making some large changes to the same
subsystem at the same time.

I really want to burn all my sound hardware after I'm done with my
fixes.