cvs commit: src/usr.bin/login Makefile

[Bruce Evans]

On Fri, 27 Feb 2004, Nate Lawson wrote:

> On Fri, 27 Feb 2004, Dag-Erling Smorgrav wrote:
> >...
> > Index: src/usr.bin/login/Makefile
> > diff -u src/usr.bin/login/Makefile:1.44 src/usr.bin/login/Makefile:1.45
> > --- src/usr.bin/login/Makefile:1.44	Fri Feb 27 00:39:16 2004
> > +++ src/usr.bin/login/Makefile	Fri Feb 27 09:50:59 2004
> > @@ -7,6 +7,11 @@
> >  DPADD=	${LIBUTIL} ${LIBPAM}
> >  LDADD=	-lutil ${MINUSLPAM}
> >  MAN=	login.1 login.access.5
> > +.ifdef NO_SETUID_LOGIN
> > +BINOWN= root
> > +BINMODE=4555
> > +INSTALLFLAGS=-fschg
> > +.endif
> >  NEED_LIBNAMES= yes
> >
> >  .include <bsd.prog.mk>
>
> I believe this should be ifndef for the proper behavior.

More precisely, it should be ".if !defined(...)".  "ifndef" is a style
bug in Makefiles.  It is only used in 4 makefiles in src.  Note that
the normal style for this in Makfiles is exactly the opposite of the
normal style for this in C programs.

Bruce