cvs commit: src/sys/alpha/alpha mem.c promcons.c src/sys/alpha/tlsb zs_tlsb.c src/sys/amd64/amd64 mem.c src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_ch.c scsi_pass.c scsi_pt.c s

[Poul-Henning Kamp]

In message <20040221154636.U52892 at pooker.samsco.home>, Scott Long writes:
>On Sat, 21 Feb 2004, Poul-Henning Kamp wrote:
>> phk         2004/02/21 13:10:55 PST
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>   Log:
>>   Device megapatch 4/6:
>>
>>   Introduce d_version field in struct cdevsw, this must always be
>>   initialized to D_VERSION.
>>
>>   Flip sense of D_NOGIANT flag to D_NEEDGIANT, this involves removing
>>   four D_NOGIANT flags and adding 145 D_NEEDGIANT flags.
>>
>
>Since this is a fundamental API change for drivers, please send a HEADS-UP
>to the mailing list to remind everyone to recompile their kernel modules.
>Also, what is the effect on the drivers that are in the ports tree?  Until
>these driver get updated for this change, will they still be able to work
>(assuming a recompile happens) even with this field left uninitialized?
>If not, can you put in a some temporary code to notify the user of the
>problem and allow for a 4-5 week grace period?

You did no doubt notice the "4/6" above.

If you see the 6/6 commit message, you will notice that the D_VERSION
is now enforced.  Drivers which do not initialize d_version correctly
will result in a console warning and the driver being disabled.

A grace period is not possible, that is why I have been so vocal
with my heads-up messages to current for the last two weeks.

Drivers need only to add the following two lines to work:

		.d_version = 	D_VERSION,
		.d_flags = 	D_NEEDGIANT,

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.