cvs commit: src/contrib/groff FREEBSD-Xlist src/contrib/groff/src/include getopt.h src/contrib/groff/src/libs/libgroff getopt.c getopt1.c

[Nate Lawson]

On Wed, 18 Feb 2004, Ruslan Ermilov wrote:
> On Wed, Feb 18, 2004 at 07:02:53AM +0100, Ollivier Robert wrote:
> > According to Andrey Chernov:
> > > > According to Andrey A. Chernov:
> > > > >   1.3       +2 -0      src/contrib/groff/FREEBSD-Xlist
> > > > >   1.2       +0 -169    src/contrib/groff/src/include/getopt.h (dead)
> > > > >   1.2       +0 -1055   src/contrib/groff/src/libs/libgroff/getopt.c (dead)
> > > > >   1.2       +0 -188    src/contrib/groff/src/libs/libgroff/getopt1.c (dead)
> >
> > > that it will be replacement for gnu getopt (as for fnmatch, stpcpy etc gnu
> > > pollution). getopt_long() was too long in the libc to really trigger the
> > > switch now. I don't take files off the branch, just remove unneded junk,
> > > most of it is already in FREEBSD-Xlist. It always be our style to not
> > > import unneeded files.
> >
> > Look at the commit message, these files were on the FSF vendor branch, you
> > have taken these off that branch!  That's _not_ the way you should have done
> > it.
>
> Removing files on the HEAD branch is somewhat rather special way
> to "take files off the vendor branch", and as Andrey already
> pointed out, we needed to remove at least getopt.h so the
> FreeBSD's native version of getopt.h gets used.  And there was
> no point keeping other getopt*.c either with this change.

This is not the appropriate way to do it.  des@, roberto@, and myself
have all explained this both times this has happened.

-Nate