cvs commit: src/sys/dev/ata ata-queue.c

[Brian Fundakowski Feldman]

On Thu, Dec 23, 2004 at 01:07:19PM +0000, Paul Richards wrote:
> On Thu, Dec 23, 2004 at 12:37:48AM +0100, Simon L. Nielsen wrote:
> > On 2004.12.08 11:16:33 +0000, S?ren Schmidt wrote:
> > > sos         2004-12-08 11:16:33 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/dev/ata          ata-queue.c 
> > >   Log:
> > >   Reset timeout when we are back from interrupt.
> > >   
> > >   Revision  Changes    Path
> > >   1.41      +3 -0      src/sys/dev/ata/ata-queue.c
> > 
> > This breaks my wonderful CDRW/DVD drive, which you have come to like
> > so much.
> > 
> > It fails to boot more or less like in the past with a memory modified
> > after free.  I don't have console output or trace, but i can get it if
> > you need it.
> > 
> > Let me know if you need me to test something.
> 
>  have separate CDRW and DVD and I saw this even before this patch,
> I have atapi dma turned off because the machine won't boot and
> throws the memory modified panics you describe otherwise.

These are probably generic issues related to the detachment of drives
at the wrong time (lifetime, queue synchronization, and timeout issues).
I don't recall them ever actually being fixed, but I personally was
not able to find and fix all of them, so I don't have much help to
provide here.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\