cvs commit: src/sys/dev/acpica acpi.c

[Warner Losh]

From: "Poul-Henning Kamp" <phk at phk.freebsd.dk>
Subject: Re: cvs commit: src/sys/dev/acpica acpi.c 
Date: Sun, 05 Dec 2004 23:19:39 +0100

> In message <41B388C6.5090409 at root.org>, Nate Lawson writes:
> >M. Warner Losh wrote:
> >> In message: <200412050135.iB51ZJJl040909 at repoman.freebsd.org>
> >>             Nate Lawson <njl at FreeBSD.org> writes:
> >> :   If we are resuming non-MPSAFE drivers, they need Giant held for them.
> >> 
> >> Generally, when walking the device tree, one must have Giant.  I've
> >> been meaning to add asserts for this in the tree...  I think that we
> >> have enough things giant is pushed out of that it is time...
> >
> >I'd like that.  I think the GIANT_REQUIRED asserts should go in the 
> >root_bus suspend/resume/shutdown methods, not in acpi.  This will cover 
> >everyone unless a driver drops Giant and doesn't reacquire it (unlikely).
> 
> In Geom I assert after I call driver methods, just to catch that case
> as well.

Excellent idea...

Warner