cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label src/sys/geom/stripe g_stripe.c

[Roman Kurakin]

Pawel Jakub Dawidek wrote:

>On Thu, Aug 26, 2004 at 02:56:12PM +0200, Poul-Henning Kamp wrote:
>+> In message <200408261242.i7QCgl7m012027 at repoman.freebsd.org>, Pawel Jakub Dawid
>+> ek writes:
>+> 
>+> >  Log:
>+> >  Skip providers with not defined sector size.
>+> 
>+> This is wrong.  A provider with a non-zero access count should always
>+> have a sector size.  The sectorsize can not be trusted if the access
>+> counts are zero.
>
>Yes, I know that it should be done this way, but I'm not going to fix
>atapi-cd.c, scsi_da.c and scsi_cd.c and who knows what else.
>Those classes set error to 0 even when provider has not sectorsize
>and mediasize defined.
>  
>
Does your code print any warning message in that case?
That could force authors of 'buggy' code to fix it.

rik