cvs commit: src/sys/sys mdioctl.h src/sys/modules/md Makefile src/sbin/mdconfig mdconfig.c

[Ruslan Ermilov]

On Tue, Aug 10, 2004 at 07:49:13AM -0700, John-Mark Gurney wrote:
> Ruslan Ermilov wrote this message on Tue, Aug 10, 2004 at 15:23 +0300:
> > On Mon, Aug 09, 2004 at 06:45:21AM +0000, John-Mark Gurney wrote:
> > > jmg         2004-08-09 06:45:21 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/sys              mdioctl.h 
> > >     sys/modules/md       Makefile 
> > >     sbin/mdconfig        mdconfig.c 
> > >   Log:
> > >   change the name of the md module, to g_md, introduce a define with the
> > >   name MD_MODNAME, and make mdconfig use this new define...
> > >   
> > >   Revision  Changes    Path
> > >   1.33      +1 -1      src/sbin/mdconfig/mdconfig.c
> > >   1.13      +1 -1      src/sys/modules/md/Makefile
> > >   1.16      +1 -0      src/sys/sys/mdioctl.h
> > > 
> > Why the change in the first place?
> 
> so that mdconfig does not try to load the md kernel module twice, and
> cause your machine to panic.
> 
> With a recent commit of phk's to md that converts it to geom, he removed
> the previous DECLARE_MODULE w/ the name of md, and so the md module was
> no longer implementing the md module, only the g_md module.  On my box
> that is using mfs, mdconfig would then try to load the md module a
> second time causing geom to panic.
> 
Thanks a bunch for explaining!

> I then realized that since md is now a full on geom module, it should
> be renamed to geom_md like all the other geom modules...  I still need
> to ask cvs@ to repo copy the module Makefiles into modules/geom/md...
> 
Yes, please.  I wondered about this too (why it was not named geom_md).

Another thing I'm worried about is that it's typical for a "device foo"
to have the corresponding foo.ko module, and now this is no longer the
case.  I think many would still prefer that the file be named md.ko,
while clearly the inside module should be named "g_md".


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040810/76c780a6/attachment.bin