cvs commit: src/sys/boot/i386/boot2 boot1.S sio.S src/sys/boot/i386/btx/btx btx.S src/sys/boot/i386/btx/btxldr btxldr.S src/sys/boot/i386/libi386 amd64_tramp.S src/sys/boot/i386/pxeldr pxeldr.S

[Ruslan Ermilov]

On Wed, Apr 28, 2004 at 11:06:13AM -0400, John Baldwin wrote:
> On Wednesday 28 April 2004 10:31 am, Ruslan Ermilov wrote:
> > ru          2004/04/28 07:31:44 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/boot/i386/boot2  boot1.S sio.S
> >     sys/boot/i386/btx/btx btx.S
> >     sys/boot/i386/btx/btxldr btxldr.S
> >     sys/boot/i386/libi386 amd64_tramp.S
> >     sys/boot/i386/pxeldr pxeldr.S
> >   Log:
> >   After talking to Bruce Evans and reading more standards specs,
> >   switch to using C99-style comments everywhere in preprocessed
> >   assembler.  The reason is that lines starting with the regexp
> >   '^[[:space:]]#' are treated as preprocessing directives, and
> >   while it seems to work now with GCC, it's not necessarily has
> >   to work.  Use C99 comments `//' for the trailing comments to
> >   save whitespace.
> 
> Well, that just killed any local diff's anyone had to the boot code for a 
> trivial reason.  as(1) worked just fine, I don't see why it's such a cardinal
> sin to use as(1) to compile asm files.
> 
The problem is not with as(1) but with cpp(1) -- as explained in
the commit log our comments weren't strictly speaking comments
per se, yet you were the one who pointed this out once to me
when I switched from m4(1) preprocessed .s files to cpp(1)
preprocessed .S files.

> Thanks for not even asking before hosing the history in cvs annotate:
> 
The history is still here, ``cvs annotate -rX.Y'' still works.

> > grep jhb /usr/src/MAINTAINERS
> cdboot          jhb     Pre-commit review requested.
> pxeboot         jhb     Pre-commit review requested.
> witness         jhb     Pre-commit review requested.
> sys/boot/i386/cdboot/Makefile:MAINTAINER=       jhb at FreeBSD.org
> sys/boot/i386/pxeldr/Makefile:MAINTAINER=       jhb at FreeBSD.org
> 
I don't look into makefiles for MAINTAINER bits anymore, and
you'd better renaming "pxeboot" to "pxeldr" in src/MAINTAINERS.

In any case, please feel free to revert the pxeldr/ or other
changes if they damage some of your real work; just let me
know when it's safe to reapply my .S comment fixes.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040428/b76d765d/attachment.bin