cvs commit: src/sys/dev/sound/pci cmi.c

[Brian F. Feldman]

Alexander Leidinger <Alexander at Leidinger.net> wrote:
> On Tue, 20 Apr 2004 21:23:51 -0700 (PDT)
> Brian Feldman <green at freebsd.org> wrote:
> 
> > green       2004/04/20 21:23:51 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/sound/pci    cmi.c 
> >   Log:
> >   This driver certainly works fine turning INTR_MPSAFE back on.  For those
> >   of you with other cards, please do review and test the drivers for
> >   MP-safety and disable Giant in the interrupt routines when you are
> >   sure of proper functionality.
> 
> How to test it? Just mark it as MP-safe and play some audio?

In this case, I reviewed the lock usage in the code to make sure that it 
protected the softc correctly, and to make sure I tested out all of the play 
and all of the record channels and the mixer at once.  I don't think that 
there is really any more you could do than that, and luckily, the drivers 
are generally simple.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\