cvs commit: src/usr.bin/mt mt.c

[Ruslan Ermilov]

On Fri, Apr 09, 2004 at 07:19:27AM -0700, Maxime Henrion wrote:
> mux         2004/04/09 07:19:12 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.bin/mt           mt.c 
>   Log:
>   Reintroduce a comment that was wrongly removed in revision 1.34.
>   
>   Revision  Changes    Path
>   1.35      +4 -0      src/usr.bin/mt/mt.c
> 
Err, the weirdness was that different drivers returned different MT_*'s:

-       /*
-        * XXX This is weird.  The st driver reports the tape drive
-        * as 0x7 (MT_ISAR - Sun/Archive compatible); the wt driver
-        * either reports MT_ISVIPER1 for an Archive tape, or 0x11
-        * (MT_ISMFOUR) for other tapes.
-        * XXX for the wt driver, rely on it behaving like a "standard"
-        * magtape driver.

> Index: src/usr.bin/mt/mt.c
> diff -u src/usr.bin/mt/mt.c:1.34 src/usr.bin/mt/mt.c:1.35
> --- src/usr.bin/mt/mt.c:1.34	Sun Mar 14 04:09:43 2004
> +++ src/usr.bin/mt/mt.c	Fri Apr  9 07:19:12 2004
> @@ -44,7 +44,7 @@
>  #endif /* not lint */
>  
>  #include <sys/cdefs.h>
> -__FBSDID("$FreeBSD: /repoman/r/ncvs/src/usr.bin/mt/mt.c,v 1.34 2004/03/14 12:09:43 ru Exp $");
> +__FBSDID("$FreeBSD: /repoman/r/ncvs/src/usr.bin/mt/mt.c,v 1.35 2004/04/09 14:19:12 mux Exp $");
>  
>  /*
>   * mt --
> @@ -312,6 +312,10 @@
>  	char	*t_dsbits;	/* "drive status" register */
>  	char	*t_erbits;	/* "error" register */
>  } tapes[] = {
> +	/*
> +	 * XXX This is weird.  The st driver reports the tape drive
> +	 * as 0x7 (MT_ISAR - Sun/Archive compatible).
> +	 */
>  	{ MT_ISAR,	"SCSI tape drive", 0,		0 },
>  	{ 0, NULL, 0, 0 }
>  };

I don't see how this comment applies today and in its current shape.

In any case, I'd appreciate it if you notified me about what I did
wrong before committing.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040409/a92971d2/attachment.bin