cvs commit: src/sys/net if_gif.c

[Ruslan Ermilov]

On Wed, Mar 31, 2004 at 09:06:56AM -0500, Robert Watson wrote:
> 
> On Wed, 31 Mar 2004, Ruslan Ermilov wrote:
> 
> > > > Implemented this in the attached patch.  Note when testing: setting
> > > > net.link.gif.max_nesting too high (>20 on my system) and triggering
> > > > the recursion causes the kernel stack exhaustion.
> > > 
> > > Why not just do what OpenBSD does and do actual loop detection?  This
> > > gets rid of the nesting count hack which isn't really what you want to
> > > measure anyway.
> > > 
> > > http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/if_gif.c.diff?r1=1.18&r2=1.19
> > > 
> > Good idea.  I will implement it and repost the updated patch here.
> 
> While you're at it, we also need loop detection in if_gre.  Make sure to
> check the IP- and IPv6-layer pieces of these as well.
> 
Um, what do you mean, should I _check_ by running, or what?


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040405/91f38335/attachment.bin