cvs commit: src/sys/dev/streams streams.c src/sys/kern kern_descrip.c kern_event.c sys_pipe.c uipc_syscalls.c vfs_syscalls.c src/sys/opencrypto cryptodev.c

David Malone dwmalone at maths.tcd.ie
Sun Oct 19 14:51:36 PDT 2003


> For example, some of the file descriptor handling during execve(), in
> kqueue_register(), unp_externalize(), the /dev/fd code, et al.  We need to
> either pick to have the file descriptor locks in the lock order before
> Giant, or after Giant, and right now we're in limbo, so Witness generates
> lock order warnings... 

The code I've been looking at is mainly syscall code, and this grab
Giant first and then grab the file descriptor lock. I don't plan
to change the lock order here, but rather avoid grabbing Giant where
it isn't needed any longer. I guess this may indirectly help if I
can reduce the number of places where Giant and the file descriptor
lock are held at the same time.

	David.


More information about the cvs-src mailing list