cvs commit: src/sys/kern sys_pipe.c

[John-Mark Gurney]

Poul-Henning Kamp wrote this message on Sun, Oct 12, 2003 at 10:05 +0200:
> In message <200310120706.h9C763U6085132 at repoman.freebsd.org>, John-Mark Gurney 
> writes:
> >jmg         2003/10/12 00:06:03 PDT
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/kern             sys_pipe.c 
> >  Log:
> >  fix a problem referencing free'd memory.  This is only a problem for
> >  kqueue write events on a socket and you regularly create tons of pipes
> >  which overwrites the structure causing a panic when removing the knote
> >  from the list.  If the peer has gone away (and it's a write knote), then
> >  don't bother trying to remove the knote from the list.
> 
> Does this fix make(1) compiled with -DUSE_KQUEUE ?

Hmmm.. After looking at the make source, no, it probably doesn't.  The
bug this fixed was limited to EVFILT_WRITE events being registered on
pipes, and make(1) doesn't use EVFILT_WRITE.

Do we have a back trace on the problem with make?

(I couldn't find a PR on it.)

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."