cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3
sbread.3 ufs_disk_close.3
Hiten Pandya
hmp at nxad.com
Thu Oct 9 13:22:15 PDT 2003
On Thu, Oct 09, 2003 at 07:13:55AM -0500, Jacques A. Vidrine wrote:
: I think you removed the wrong header. Is <sys/param.h> required in
: each of these cases? If not, then I believe the synopsis should refer
: only to <sys/types.h>:
:
: (1) Including <sys/types.h> is (by definition) less work than
: <sys/param.h>.
I remove the most logical one and also, there was some
discussion about it on IRC. Also, I was doing an mdoc
review of all the lib manual pages, and I thought I would fix
this, but I did not do a deep code review to see which header
fits best for libufs, as I did not see a reason for it.
: (2) <sys/types.h> is a POSIX header, while <sys/param.h> is not.
LibUFS is not a POSIX library anyway, so I don't see what this
has got to do with anything. If anyone is inclined on me
backing this out, I don't mind, although, I made a
judgement/logical call when committing this.
Regards,
--
Hiten Pandya
hmp at FreeBSD.ORG, hmp at backplane.com
More information about the cvs-src
mailing list