cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3 sbread.3 ufs_disk_close.3

Jacques A. Vidrine nectar at FreeBSD.org
Thu Oct 9 05:13:58 PDT 2003


On Thu, Oct 09, 2003 at 02:45:20AM -0700, Hiten Pandya wrote:
> hmp         2003/10/09 02:45:20 PDT
> 
>   FreeBSD src repository (doc committer)
> 
>   Modified files:
>     lib/libufs           bread.3 cgread.3 getino.3 libufs.3 
>                          sbread.3 ufs_disk_close.3 
>   Log:
>   Remove unneccessary include of sys/types.h in the SYNOPSIS
>   header.
>   
>   Sys/param.h includes sys/types.h internally unless LOCORE is
>   defined.
>   
>   Approved by:    des (mentor)

I think you removed the wrong header.  Is <sys/param.h> required in
each of these cases?  If not, then I believe the synopsis should refer
only to <sys/types.h>:

  (1) Including <sys/types.h> is (by definition) less work than
      <sys/param.h>.

  (2) <sys/types.h> is a POSIX header, while <sys/param.h> is not.

Cheers,
-- 
Jacques Vidrine   . NTT/Verio SME      . FreeBSD UNIX       . Heimdal
nectar at celabo.org . jvidrine at verio.net . nectar at freebsd.org . nectar at kth.se


More information about the cvs-src mailing list