cvs commit: src/sys/kern kern_intr.c

Nate Lawson nate at root.org
Tue Nov 18 16:46:26 PST 2003


On Wed, 19 Nov 2003, Bruce Evans wrote:
> On Tue, 18 Nov 2003, Mark Murray wrote:
>
> > markm       2003/11/18 06:35:43 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/kern             kern_intr.c
> >   Log:
> >   Hackfix to patch around a kernel panic I introduced. Real fix to
> >   follow. In the meanwhile, we are not harvesting interrupt entropy.
> >
> >   Approved by:    re (jhb)
>
> The correct fix is approximately to back out the changes to the
> harvester.  It needs to use preallocated storage like it used to since
> it is called from nearly the lowest level of interrupt handling when
> neither malloc() nor sleep locks may be used.  Using preallocated storage
> also simplifies the locking.

I agree.  Separating the buffer into per-source buffers does not require
changing from a ring buffer to a malloc/FIFO model.

-Nate


More information about the cvs-src mailing list