cvs commit: src/sys/netinet ip_fastfwd.c

Nate Lawson nate at root.org
Sat Nov 15 12:11:46 PST 2003


On Sat, 15 Nov 2003, Andre Oppermann wrote:
>   Modified files:
>     sys/netinet          ip_fastfwd.c
>   Log:
>   Correct a cast to make it compile on 64bit platforms (noticed by tinderbox)
>   and remove two unneccessary variable initializations.
>   Make the introduction comment more clear with regard which parts of
>   the packet are touched.
>
>   Requested by:   luigi
>
>   Revision  Changes    Path
>   1.2       +6 -6      src/sys/netinet/ip_fastfwd.c
>
> --- src/sys/netinet/ip_fastfwd.c:1.1	Fri Nov 14 13:02:21 2003
> +++ src/sys/netinet/ip_fastfwd.c	Sat Nov 15 09:03:37 2003
> @@ -567,7 +567,7 @@
>  					goto drop;
>  				}
>  				tag->m_flags = PACKET_TAG_DIVERT;
> -				tag->m_data = (caddr_t)(u_int32_t)args.divert_rule;
> +				tag->m_data = (caddr_t)(u_long)args.divert_rule;
>  				tag->m_next = m;
>  				/* XXX: really bloody hack, see ip_input */
>  				tag->m_nextpkt = (struct mbuf *)1;

I believe this cast is still bogus.  You want uintptr_t.

-Nate


More information about the cvs-src mailing list