cvs commit: src/sys/kern kern_timeout.c

Kirk McKusick mckusick at beastie.mckusick.com
Thu Nov 13 12:24:05 PST 2003


> Date: Wed, 12 Nov 2003 19:03:07 -0500 (EST)
> From: Robert Watson <rwatson at FreeBSD.org>
> X-Sender: robert at fledge.watson.org
> To: Kirk McKusick <mckusick at FreeBSD.org>
> Cc: src-committers at FreeBSD.org, cvs-src at FreeBSD.org, cvs-all at FreeBSD.org
> Subject: Re: cvs commit: src/sys/kern kern_timeout.c
> In-Reply-To: <200311122228.hACMSSwZ027025 at repoman.freebsd.org>
> 
> On Wed, 12 Nov 2003, Kirk McKusick wrote:
> 
> > mckusick    2003/11/12 14:28:28 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/kern             kern_timeout.c 
> >   Log:
> >   At the request of several developers, restore the DIAGNOSIC code
> >   deleted in 1.81. Increase the initial timeout limit to 2ms to
> >   eliminate spurious messages of excessive timeouts in the NFS
> >   client code.
> >   
> >   Requested by:   Poul-Henning Kamp <phk at phk.freebsd.dk>
> >   Requested by:   Mike Silbersack <silby at silby.com>
> >   Requested by:   Sam Leffler <sam at errno.com>
> 
> Could this have been responsible for the apparent hangs some (few but
> unfortunate) users were seeing with NFS, frequently accompanied by notices
> that the NFS server was unreachable? 
> 
> Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
> robert at fledge.watson.org      Network Associates Laboratories

The above code is only included when DIAGNOSTIC is defined and
is purely diagnostic (printing out a warning when an event called
from the timeout queue takes longer than the threshhold: formerly
1ms now 2ms). So, at best it might have provided a warning. It
certainly could not have caused/fixed the problem.

	Kirk McKusick


More information about the cvs-src mailing list