cvs commit: src/sys/netinet tcp_syncache.c

Mike Silbersack silby at silby.com
Mon Nov 10 20:02:57 PST 2003


On Mon, 10 Nov 2003, M. Warner Losh wrote:

> In message: <200311102359.hAANx2xu023566 at mta7.pltn13.pbi.net>
>             Jeffrey Hsu <hsu at FreeBSD.org> writes:
> : Are you kidding me?  Or do you really not understand why it's not
> : Giant-free ready yet?
>
> While it may be obvious to you, it seems that a sentence or two about
> how it isn't giant-free would be useful.
>
> Warner

If I'm not mistaken, syncache_timer calls syncache_respond, which then
goes and interacts with the routing table and ip stack.  Along with the
rest of the non-locked code, it sure looks like it's not-MPSAFE to me.

It seems "obvious" that the code isn't giant-free, given that there are no
locking assertions in it whatsoever.

Mike "Silby" Silbersack


More information about the cvs-src mailing list