cvs commit: src/contrib/gcc c-lex.c

[Ruslan Ermilov]

On Sat, Nov 08, 2003 at 07:55:31PM +1100, Bruce Evans wrote:
> On Fri, 7 Nov 2003, Ruslan Ermilov wrote:
> 
> > On Sat, Nov 08, 2003 at 02:36:09AM +1100, Bruce Evans wrote:
> > > On Fri, 7 Nov 2003, Ruslan Ermilov wrote:
> > >
> > > > On Thu, Nov 06, 2003 at 07:09:40PM -0800, Alexander Kabaev wrote:
> > > > > kan         2003/11/06 19:09:40 PST
> > > > >
> > > > >   FreeBSD src repository
> > > > >
> > > > >   Modified files:
> > > > >     contrib/gcc          c-lex.c
> > > > >   Log:
> > > > >   Drop the revision 1.2 (don't let gcc(1) hide warnings in system headers)
> > > > >   and use stock version of this file now.
> > > > >   ...
> > > >
> > > > Will -Wsystem-headers from bsd.sys.mk for WARNS > 0 still take care
> > > > of emitting warnings in system headers?
> > >
> > > If WARNS > 0 it will :-).  I think we have enough WARNS > 0 to catch
> > > most problems, but developers, especially bde and ru, should run with
> > > -Wsystem-headers unconditional in bsd.sys.mk.
> > >
> > I mean, does -Wsystem-headers affect both cc(1) and cpp(1) now?
> 
> Yes, but I think your question is whether we enable it for cpp.  We don't
> do anything except enable it in CFLAGS if WARNS > 0 AFAIK, so only
> invocations of cpp that use CFLAGS get it.  This may be enough.
> 
OK, I now recall -- there was no such thing like -Wsystem-headers
in 2.95.x and probably 3.0, where these local mods were originally
made, and I now see that it affects both cpp(1) and gcc(1), thanks.

My main concern, as I already told you in private, is to keep
buildworld and "make all" types of builds consistent; previously,
buildworld used the ``-nostdinc -I${WORLDTMP}/usr/include'' hack,
that caused harm in this area (system headers were not treated
as system), now that this hack is gone, I'm happy.  ;-)


Cheers,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru at sunbay.com		Sunbay Software Ltd,
ru at FreeBSD.org		FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20031108/6e875905/attachment.bin