cvs commit: src/sys/kern kern_timeout.c

[M. Warner Losh]

In message: <200311040910.54728.sam at errno.com>
            Sam Leffler <sam at errno.com> writes:
: On Tuesday 04 November 2003 12:45 am, Poul-Henning Kamp wrote:
: > In message <20031104022403.J625 at odysseus.silby.com>, Mike Silbersack writes:
: > >On Tue, 4 Nov 2003, Kirk McKusick wrote:
: > >> mckusick    2003/11/04 00:03:11 PST
: > >>
: > >>   FreeBSD src repository
: > >>
: > >>   Modified files:
: > >>     sys/kern             kern_timeout.c
: > >>   Log:
: > >>   Get rid of DIAGNOSTIC that gives false positives on slow CPUs.
: > >
: > >That doesn't seem to be a very good reason for removing the code.  As only
: > >the highest value seen so far is printed, the code is generally pretty
: > >quiet once it stops complaining about how long the MII routines take.
: >
: > I agree, I am unhappy about this removal too.
: 
: Please revert this change.

It seems to me that DIAGNOSTIC should be disabled on those slow CPUs.
How slow do you need to trigger the bug?  If slow is 1GHz that's one
thing, but if slow is 166MHz, then that's another :-)

Please revert.  If you are unhappy about false positives, then the
timeout interval likely should be tuned.

Warner