cvs commit: src/sys/alpha/alpha machdep.c src/sys/alpha/osf1 osf1_signal.c src/sys/amd64/amd64 machdep.c src/sys/compat/linprocfs linprocfs.c src/sys/compat/svr4 svr4_filio.c svr4_misc.c src/sys/i

[Bruce Evans]

On Thu, 15 May 2003, John Baldwin wrote:

> On 15-May-2003 Bruce Evans wrote:
> > On Wed, 14 May 2003, John Baldwin wrote:
> >
> >> On 14-May-2003 Kimura Fuyuki wrote:
> >> > At Tue, 13 May 2003 13:36:02 -0700 (PDT),
> >> > John Baldwin <jhb at freebsd.org> wrote:
> >> >>   1.61      +23 -4     src/sys/sys/signalvar.h
> >> >
> >> > There seems to be missing #include <sys/queue.h>.
> >>
> >> Yes. :(  I wonder if it shouldn't be in sys/_lock.h
> >> instead.
> >
> > Less than it should include <sys/types.h> for its use of u_int (i.e.,
> > it shouldn't).
>
> Hmm, I can fix it to use unsigned instead if that is preferred:

There's not much point, since other typedefs are needed (e.g., uintptr_t
in <sys/_mutex.h>.  Also, `unsigned' is messes up the formatting in
<sys/_lock.h>.  The rule for when to use u_int vs. `unsigned' is more or
less "always use u_int" in kernel only [parts of] headers; never use it
in application headers".

Bruce