cvs commit: src/share/man/man4 umass.4 src/sys/dev/usb umass.c usbdevs

Dag-Erling Smorgrav des at ofug.org
Tue May 13 08:23:51 PDT 2003


"M. Warner Losh" <imp at bsdimp.com> writes:
> OK.  I'll use your stuff and merge it into the bigger mii/pccard
> picture.  I see why it works, but it is a little different than the
> foo_if.h stuff, which we have to list explicitly...

Yes, it's a hack taking advantage of the fact that everything that
relates to USB includes opt_usb.h...  I did it precisely to avoid
having to modify the module Makefiles.  It's ugly as sin though, and
changing the Makefiles to explicitly list usbdevs.h is probably better
in the long run.

One other thing: my patch does not add usbdevs{,_data}.h to
CLEANFILES, which it should - but doing it unconditionally is kinda
yucky, and I can't see a way to do it conditionally.

We should probably have something in kmod.mk similar to the USE_*
stuff in bsd.port.mk - USE_MII, USE_USB, etc.

DES
-- 
Dag-Erling Smorgrav - des at ofug.org


More information about the cvs-src mailing list