cvs commit: src/share/man/man4 umass.4 src/sys/dev/usb umass.c usbdevs

M. Warner Losh imp at bsdimp.com
Tue May 13 07:36:36 PDT 2003


In message: <xzphe7zmb45.fsf at flood.ping.uio.no>
            Dag-Erling Smorgrav <des at ofug.org> writes:
: Dag-Erling Smorgrav <des at ofug.org> writes:
: > "M. Warner Losh" <imp at bsdimp.com> writes:
: > > This patch doesn't address those drivers that might wish to build not
: > > in the usb.ko module, for example the urio driver and I'm sure others.
: > I know.  I did mention that it was incomplete, didn't I?
: 
: This one should be a little better.  The second patch fixes the
: #include lines.  It would be advantageous if the awk script could
: generate usbdevs.h and usbdevs_data.h separately, as the latter is
: only required by the usb driver and it's a waste of time and space to
: generate it for all the other drivers.

The makefiles for the modules still need to be included.  I think I
like my approach a little better, but it has the flaw of not
necessarily generating usbdevs_data.h if usbdevs.h isn't generated.
Since usbdevs_data.h is used only when USBVERBOSE is defined, I would
have thought that we'd not need it (since USBVERBOSE is supposed to be
an option), but it looks like it is always defined, so we get a lot of
extra junk in our usb.ko module, even on install media...

Warner


More information about the cvs-src mailing list