cvs commit: src/sys/i386/i386 identcpu.c

[Poul-Henning Kamp]

In message <20030430184351.B31859 at espresso.bsdmike.org>, Mike Barcroft writes:
>Mark Murray <markm at FreeBSD.org> writes:
>> markm       2003/04/30 05:23:58 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/i386/i386        identcpu.c 
>>   Log:
>>   Warns fixing. Protect against inappropriate linting, and mark
>>   GCC-specific assemble code as such (in #ifdefs). Fix an easy
>>   static variable warning while I'm here.
>>   
>>   Revision  Changes    Path
>>   1.122     +8 -1      src/sys/i386/i386/identcpu.c
>
>Is it really useful to #ifdef critical sections of code.  This thing
>isn't going to compile without asm extentions from the compiler.  So
>really you just turn compile errors into link error.  Not very helpful
>IMO.

Yes, it is useful, because it allows us to run code validation tools
on our source code.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.