cvs commit: src/sys/kern kern_thread.c src/sys/sys kse.h

[David Xu]

Thank you!

----- Original Message -----=20
From: "Marcel Moolenaar" <marcel at FreeBSD.org>
To: <src-committers at FreeBSD.org>; <cvs-src at FreeBSD.org>; =
<cvs-all at FreeBSD.org>
Sent: Sunday, June 29, 2003 3:45 AM
Subject: cvs commit: src/sys/kern kern_thread.c src/sys/sys kse.h


> marcel      2003/06/28 12:45:15 PDT
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     sys/kern             kern_thread.c=20
>     sys/sys              kse.h=20
>   Log:
>   Don't use fuword() and suword() on struct members of type int. This
>   happens to work on 32-bit platforms as sizeof(long)=3Dsizeof(int), =
but
>   wrecks all kinds of havoc (garbage reads, corrupting writes and
>   misaligned loads/stores) on 64-bit architectures.
>   The fix for now is to use fuword32() and suword32() and change the
>   type of the applicable int fields to int32. This is to make it
>   explicit that we depend on these fields being 32-bit. We may want
>   to revisit this later.
>  =20
>   Reviewed by: deischen
>  =20
>   Revision  Changes    Path
>   1.147     +4 -4      src/sys/kern/kern_thread.c
>   1.17      +3 -3      src/sys/sys/kse.h
>