cvs commit: src/sys/kern kern_prot.c

[Nate Lawson]

On Wed, 25 Jun 2003, Olivier Houchard wrote:
>   Modified files:
>     sys/kern             kern_prot.c
>   Log:
>   At this point targp will always be NULL, so remove the useless if.
>
>   Revision  Changes    Path
>   1.173     +0 -2      src/sys/kern/kern_prot.c
>
> --- src/sys/kern/kern_prot.c:1.172	Sun Jun 15 08:57:42 2003
> +++ src/sys/kern/kern_prot.c	Wed Jun 25 06:28:32 2003
> @@ -404,8 +404,6 @@
>  	sx_xlock(&proctree_lock);
>  	if (uap->pid != 0 && uap->pid != curp->p_pid) {
>  		if ((targp = pfind(uap->pid)) == NULL) {
> -			if (targp)
> -				PROC_UNLOCK(targp);
>  			error = ESRCH;
>  			goto done;
>  		}

Did you intend to remove the PROC_UNLOCK along with the 'if'?  It seems
it is still needed since at least the proctree_lock is still held.

-Nate