cvs commit: src/sys/dev/pccbb pccbb.c pccbbvar.h

[Andrea Campi]

On Tue, Jun 24, 2003 at 11:18:15PM -0700, Nate Lawson wrote:
> 
> Um, did you cvsup to 1.78?  I found an error in the original commit where
> it locks Giant twice (instead of unlocking) which would give exactly these
> symptoms.
> 

That's what I get for not being more careful with my diffs...
Yes, I still had trouble with 1.78; I initially had the problem with a kernel
compiled from sources cvsup'ed on Jun 20 and then Jun 24, that's why I started
tracking it down.

I've just cvsup'd again to the HEAD, applied my patch and I'm running a make
buildkernel just to be extra sure, but I think this is real.

Anyway, I'm curious - are you sure the symptoms for double locking Giant would
only be buffers not emptying, and not actually a freeze? Where would the Giant
be unlocked on the way out from the intr handler? (not a rethoric question, I
really didn't check).

I'll try playing with it. Now that I think of it, I should also recompile with
WITNESS et al. I'll get back when I know more.

Bye,
	Andrea

-- 
                Where do you think you're going today?