cvs commit: src/share/mk bsd.sys.mk

David O'Brien obrien at FreeBSD.org
Sun Jun 1 14:18:21 PDT 2003


On Sun, Jun 01, 2003 at 11:01:47PM +0200, Dag-Erling Smorgrav wrote:
> "David E. O'Brien" <obrien at FreeBSD.org> writes:
> >   Modified files:
> >     share/mk             bsd.sys.mk 
> >   Log:
> >   Compile our code as C99 by default.
> 
> Please back this out immediately.  You can't possibly have tested it;
> it breaks the build quite badly.

Show me the failure.


> I'd also like you to back out the previous commit (1.19), which made
> CSTD pretty much useless.

Take it to the TRB.  It was useless before.  One cannot even set
CSTD=gnu89, which should be a NOP.  The same failure occurs for *any*
setting of CSTD because you were too agressive with -pedantic.  Rev 1.19
returns behavior back to the behavior of the past year.


# fgrep '$FreeBSD' /usr/share/mk/bsd.sys.mk 
# $FreeBSD: src/share/mk/bsd.sys.mk,v 1.17 2003/05/05 21:14:36 des Exp $

# cd /usr/src/sbin/adjkerntz/
# CSTD=gnu89 make
cc -O -pipe -march=athlon-xp   -std=gnu89 -pedantic -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized  -c /usr/src/sbin/adjkerntz/adjkerntz.c
cc1: warnings being treated as errors
In file included from /usr/src/sbin/adjkerntz/adjkerntz.c:52:
/usr/include/sys/time.h: In function `timespec2bintime':
/usr/include/sys/time.h:125: warning: ISO C89 forbids long long integer constants
/usr/include/sys/time.h: In function `timeval2bintime':
/usr/include/sys/time.h:142: warning: ISO C89 forbids long long integer constants
/usr/src/sbin/adjkerntz/adjkerntz.c: In function `main':
/usr/src/sbin/adjkerntz/adjkerntz.c:131: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:155: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:163: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:291: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:298: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:316: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:323: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:338: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:347: warning: ISO C does not support the `%m' printf format
/usr/src/sbin/adjkerntz/adjkerntz.c:358: warning: ISO C does not support the `%m' printf format
*** Error code 1

Stop in /usr/src/sbin/adjkerntz.


More information about the cvs-src mailing list