cvs commit: src/sys/vm vm_contig.c
Alan L. Cox
alc at imimic.com
Fri Jul 25 14:11:31 PDT 2003
Maxime Henrion wrote:
>
> mux 2003/07/25 14:02:25 PDT
>
> FreeBSD src repository
>
> Modified files:
> sys/vm vm_contig.c
> Log:
> Add support for the M_ZERO flag to contigmalloc().
>
> Reviewed by: jeff
>
> Revision Changes Path
> 1.21 +5 -1 src/sys/vm/vm_contig.c
This has a bug. The page is not mapped at the time you perform
bzero(). (In fact, it is not mapped until after the vm_map_wire()
occurs.) Thus, you need to use pmap_zero_page() instead.
Your tests probably succeeded because of page prezeroing. (With
prezeroing, you never exercised the bug.)
I'm pretty sure that I sent you an e-mail about this. If not, I
apologize.
Regards,
Alan
More information about the cvs-src
mailing list