cvs commit: src/usr.sbin/lpr/lpd lpd.c ...

[Philippe Charnier]

Salut,

Garance A Drosihn <drosih at rpi.edu> wrote:

>I'm willing to go with the above for the sources in lpr if it
>is reasonable to everyone.  It's not quite what I want, but I
>probably should do something along these lines.
>
>Actually, let me take that a step further. How about I change
>all the source files to have:
>
>#include "lpr_cdefs.h"
>__FBSDID("$FreeBSD$");
>
[...]
>(note that I sometimes still compile lpr on an older release
>of freebsd, old enough that it does not have __FBSDID in it)
>
>That's probably a little ugly, but I could use it to get all of
>lpr using __FBSDID() so other developers will not feel tempted
>to add it "for me".  And, all the ugliness is off in the one
>lpr_cdefs.h file.  The nice thing about this for me is that
>I *might* even be able to use the "#ident" directive when
>compiling under IRIX, and I'll only have to change one file to
>do that.

Then we should be tempted to also add a crude hack for those OS that
do not have err() family functions, making porting easier. I think
that dealing with FBSDID is really the fastest stage of porting BSD
userland to other OS.

sys/cdefs.h seems to propose STRIP_FBSDID

------                                                            ------ 
Philippe Charnier          charnier@{xp11.frmug.org,free.fr,FreeBSD.org}

    ``a PC not running FreeBSD is like a venusian with no tentacles'' 
------------------------------------------------------------------------